Skip to content

Share PythonUtil.java between bootstraps#2188

Merged
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/share_java_python_util
May 10, 2020
Merged

Share PythonUtil.java between bootstraps#2188
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/share_java_python_util

Conversation

@AndreMiras
Copy link
Member

Note we're using addLibraryIfExists() for libraries that are needed
by the sdl2 bootstrap, but may not be compiled on other bootstraps.
This way it should fail gracefully while letting us share 100% of the code.

Note we're using `addLibraryIfExists()` for libraries that are needed
by the `sdl2` bootstrap, but may not be compiled on other bootstraps.
This way it should fail gracefully while letting us share 100% of the code.
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@AndreMiras AndreMiras merged commit eeed13c into kivy:develop May 10, 2020
@AndreMiras AndreMiras deleted the feature/share_java_python_util branch May 10, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants