Skip to content

Java code linting using PMD 6.23.0#2187

Merged
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/java_code_cleaning
May 10, 2020
Merged

Java code linting using PMD 6.23.0#2187
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/java_code_cleaning

Conversation

@AndreMiras
Copy link
Member

  • Avoid duplicate imports
  • Avoid importing anything from the package java.lang
  • Avoid unused imports
  • Avoid unused local variables
  • Avoid unused private fields
  • No need to import a type that lives in the same package
  • Unnecessary use of fully qualified name due to existing import

In the future we may want to add a dedicated Java linting job in the CI.

- Avoid duplicate imports
- Avoid importing anything from the package java.lang
- Avoid unused imports
- Avoid unused local variables
- Avoid unused private fields
- No need to import a type that lives in the same package
- Unnecessary use of fully qualified name due to existing import

In the future we may want to add a dedicated Java linting job in the CI.
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AndreMiras AndreMiras merged commit 7b27577 into kivy:develop May 10, 2020
@AndreMiras AndreMiras deleted the feature/java_code_cleaning branch May 10, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants