Skip to content

Removes java concurrency/ folder#2185

Merged
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/delete_unused_java_concurrency
May 9, 2020
Merged

Removes java concurrency/ folder#2185
AndreMiras merged 1 commit intokivy:developfrom
AndreMiras:feature/delete_unused_java_concurrency

Conversation

@AndreMiras
Copy link
Member

None of the class seems to be used.

None of the class seems to be used.
@inclement
Copy link
Member

Is there any chance there's pyjnius code using this?

@AndreMiras
Copy link
Member Author

AndreMiras commented May 9, 2020

I haven't thought about that one, I'll look into it, thanks

@AndreMiras
Copy link
Member Author

It got introduced in #578 but I still don't have it clear why 😄

Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to remove it then, with the caveat that let's just reinstate it if anyone complains.

@AndreMiras
Copy link
Member Author

yes agree, if it breaks something someone should complain. Isn't it how software development works? 😄

@AndreMiras AndreMiras merged commit 2604406 into kivy:develop May 9, 2020
@AndreMiras AndreMiras deleted the feature/delete_unused_java_concurrency branch May 9, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants