Reuse common AssetExtract.java#2182
Merged
AndreMiras merged 1 commit intokivy:developfrom May 9, 2020
Merged
Conversation
AndreMiras
commented
May 9, 2020
| def get_dist_dir(self, name): | ||
| return join(self.ctx.dist_dir, name) | ||
|
|
||
| def get_common_dir(self): |
Also removes unused `mActivity` member. Note we changed the constructor input parameter to accept a `Context` object which is a parent class of the previous `Activity` one. Changes were tested on both kivy and service_only bootstraps. Also removes the `get_common_dir()` as it's no longer used since kivy#2092
AndreMiras
force-pushed
the
feature/share_asset_extract
branch
from
ec07a4e to
4fbcefd
Compare
inclement
approved these changes
May 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes unused
mActivitymember.Note we changed the constructor input parameter to accept a
Contextobject which is a parent class of the previous
Activityone.Changes were tested on both kivy and service_only bootstraps.