Conversation
Actually simply reverted few files:
```sh
git checkout master -- \
pythonforandroid/recipes/sdl2/__init__.py \
pythonforandroid/bootstraps/sdl2/build/src/patches/SDLActivity.java.patch \
pythonforandroid/bootstraps/sdl2/build/src/main/java/org/kivy/android/PythonActivity.java
```
- fixes kivy#2167
- fixes kivy#2169
|
This fixes the issue referenced above. |
inclement
left a comment
There was a problem hiding this comment.
Looks good. The details of the PythonActivity change aren't entirely obvious to me, but I totally believe it's correct. Do you think it's worth logging somewhere (e.g. another issue) what you had to revert, so it's easier to go back to newer sdl2 versions later?
|
Thanks for the review/approval! That should be enough I think otherwise yes it doesn't hurt to create a reminder task with theses details I suppose |
Actually simply reverted few files:
git checkout master -- \ pythonforandroid/recipes/sdl2/__init__.py \ pythonforandroid/bootstraps/sdl2/build/src/patches/SDLActivity.java.patch \ pythonforandroid/bootstraps/sdl2/build/src/main/java/org/kivy/android/PythonActivity.java