Narrows some context manager scopes#2179
Merged
AndreMiras merged 1 commit intokivy:developfrom May 9, 2020
Merged
Conversation
Tries to keep the `current_directory` context manager as scoped as possible. Also use the `contextlib.suppress` context manager when appropriated as it's more concise.
opacam
approved these changes
May 8, 2020
Comment on lines
-624
to
-627
| try: | ||
| with suppress(AttributeError): | ||
| constraints = constraints.decode("utf-8", "replace") | ||
| except AttributeError: | ||
| pass |
Member
There was a problem hiding this comment.
🔥 two less lines of code without sacrificing readability 😄
Member
Author
There was a problem hiding this comment.
Yes I love that one :)
But it cannot really be used nicely if we have a large comment block above the pass, so yes I decided to introduced it only when we had a simple except ...: pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to keep the
current_directorycontext manager as scoped aspossible. Also use the
contextlib.suppresscontext manager whenappropriated as it's more concise.