Conversation
opacam
left a comment
opacam
left a comment
There was a problem hiding this comment.
👍 thanks @robertpfeiffer and @AndreMiras
I'm wondering if we should write docstring describing a little the recipe (just to avoid confusion with old pygame bootstrap). Also I would include part of the text you wrote at PR description...maybe inside a warning ref:
Some pygame functionality is still untested,
and some dependencies like freetype, postmidi and libjpeg are currently not part of the build. It's usable, but not complete.
| from pythonforandroid.recipe import CompiledComponentsPythonRecipe | ||
| from os.path import join | ||
| from pythonforandroid.toolchain import current_directory |
There was a problem hiding this comment.
nitpick: Maybe we can sort the imports
There was a problem hiding this comment.
Addressed, I wish we were linting using isort across the code base
As discussed on the Discord, this is a recipe to build apps based on SDL2-based pygame. It currently references a RC until we have an official stable release of pygame based on SDL2 with android support. Simple examples have been tested by other pygame users (it doesn't just build on my own machine) but some pygame functionality is still untested, and some dependencies like freetype, postmidi and libjpeg are currently not part of the build. It's usable, but not complete.
AndreMiras
force-pushed
the
feature/pygame_recipe
branch
from
b20fbaf to
9dded87
Compare
|
Addressed the docstring and iport sorting. I've also updated the commit message as we no longer reference a moving branch but a release candidate |
|
Looks good to me, I think. I'll make another PR after the next pygame dev release. |
|
Thanks for the feedback and for the effort, merging 🚀 |
3 participants
Edit: this authored by @robertpfeiffer I've just copy/pasted his description in the commit message, rebased and made few edits to give an example of what the PR could look like.
As discussed on the Discord, this is a recipe to build apps based on
SDL2-based pygame.
It currently references https://github.com/pygame/pygame/tree/android,
a branch that will continue to live until we have an official stable
release of pygame based on SDL2 with android support.
Simple examples have been tested by other pygame users (it doesn't just
build on my own machine) but some pygame functionality is still untested,
and some dependencies like freetype, postmidi and libjpeg are currently
not part of the build. It's usable, but not complete.