When bootstraps were unified, sources moved from src to src/main/java…#2154
Merged
AndreMiras merged 1 commit intokivy:developfrom Apr 25, 2020
Merged
When bootstraps were unified, sources moved from src to src/main/java…#2154AndreMiras merged 1 commit intokivy:developfrom
AndreMiras merged 1 commit intokivy:developfrom
Conversation
… for webview and service boostraps, so copy other sources there as well.
AndreMiras
approved these changes
Apr 25, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Nice, love the small PR addressing a single concern.
And I can't wait for our CI to also catch theses type of regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for webview and service boostraps, so copy
self.ctx.javaclass_dirsources there as well.This is needed for jnius, as it adds
org.jnius.NativeInvocationHandlertoself.ctx.javaclass_dir, but currently those sources get copied to the old root dir,src, rather than the currentsrc/main/java, which causesjniusto be unable to find that file.