Merged
Conversation
AndreMiras
approved these changes
Apr 21, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, not sure why it's not dealt with upstream
Member
|
Thanks for the fix. I've edited the commit message for slightly more explicit. |
Contributor
Author
|
Thank you! I looked around a bit, but I cannot find a ticket about this in Twisted's tracker or any info about whether they actually have an opinion or this is just how their directory structure happened to be :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update of the recipe for Twisted so that it removes the unit tests in the
prebuild_archhook. This should decrease the size from 11 down to 4 MB for the uncompressed APK directory.