recipe: update 'cryptography' and rm unnecessary dependencies#2130
Merged
AndreMiras merged 1 commit intokivy:developfrom Apr 4, 2020
Merged
recipe: update 'cryptography' and rm unnecessary dependencies#2130AndreMiras merged 1 commit intokivy:developfrom
AndreMiras merged 1 commit intokivy:developfrom
Conversation
Member
|
Thank you! |
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Apr 4, 2020
https://bitbucket.org/cffi/cffi/issues/403/build-fails-on-38-dev-pyinterpreterstate kivy#2130 (comment) The error was: ``` c/call_python.c:20:30: error: incomplete definition of type 'struct _is' ```
Contributor
Author
|
I've only tested with python 3.7 :/ |
Member
|
No worries, the fix was merged recently, could you try to rebase on develop to see if it helps with the build now? |
- 'idna' no longer needed since version 2.5 - 'asn1crypto' no longer needed since version 2.8 - 'enum34' is just a backport of python 3.4+ functionality - 'ipaddress' is just a backport of python 3.3+ functionality
SomberNight
force-pushed
the
202004_recipe_cryptography
branch
from
8eeb596 to
187f859
Compare
Contributor
Author
|
Sure, rebased now. |
AndreMiras
approved these changes
Apr 4, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Looking good thank you 😄
We had one flaky test on GitHub action due to the pyjnius patching, I've reran it, but we're good for the merge.
Thanks!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
cryptographyrecipe to a newer version, and remove unnecessary dependencies.idnano longer needed since version 2.5asn1cryptono longer needed since version 2.8enum34is just a backport of python 3.4+ functionalityipaddressis just a backport of python 3.3+ functionality(I am assuming py2 and old versions of py3 are no longer supported)