Merged
Conversation
AndreMiras
force-pushed
the
feature/minor_fixes
branch
from
b089188 to
f045e91
Compare
opacam
reviewed
Mar 31, 2020
pythonforandroid/build.py
Outdated
| ): | ||
| return True | ||
| return False | ||
| return project_dir is not None and \ |
Member
There was a problem hiding this comment.
nitpick: this backslash hurts my eyes 😆, since we touch the lines we could remove that and do it more 🐍.
- remove `object` inheritance - remove `__future__` imports - remove `six` checks and conditional imports - flat out a few for loops - fix `dir` is a reserved keyword - few more nitpick fixes
AndreMiras
force-pushed
the
feature/minor_fixes
branch
from
f045e91 to
22b7dfe
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objectinheritance__future__importssixchecks and conditional importsdiris a reserved keyword