Fix Python 3.8.1 patch naming and content#2083
Merged
opacam merged 1 commit intokivy:developfrom Mar 11, 2020
Merged
Conversation
Because:
- the name does not match the file
- `py3.8.1_fix-cortex-a8.patch` contains unneeded changes which
provokes the patching to fail
Also we add a comment to `py3.8.1_fix_cortex_a8.patch` file,
explaining why we need that patch (imho, very useful after a while...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
py3.8.1_fix-cortex-a8.patchcontains unneeded changes which provokes the patching to failAlso we add a comment to
py3.8.1_fix_cortex_a8.patchfile, explaining why we need that patch (imho, very useful after a while...)Note: The github user @Sanialtian, found this bug and notified me via email...so thanks for your debugging session and the testing!! 🙌