Fix missing renames of Bootstrap.list_bootstraps -> Bootstrap.all_bootstraps#2066
Merged
opacam merged 1 commit intokivy:developfrom Feb 21, 2020
Merged
Conversation
Member
|
Thanks!! 😄, Do you mind to rename as well this list_bootstraps entry 😬? |
opacam
previously approved these changes
Feb 21, 2020
Member
opacam
left a comment
There was a problem hiding this comment.
LGTM 👍
Note: it would be awesome if we could change the docstring I mentioned before in this PR, so we could have all the renames of list_boostraps concentrated at same PR.
a16cd60 to
e6be47a
Compare
Contributor
Author
|
@opacam I've update my PR to correct the docstring ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
p4a bootstrapcommand: