fixed patch's name to apply correctly#2064
Merged
AndreMiras merged 1 commit intokivy:developfrom Feb 18, 2020
Merged
Conversation
AndreMiras
approved these changes
Feb 18, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM thanks!
How did this even built green on Travis from the previous PR?
https://github.com/kivy/python-for-android/pull/2044/files#diff-62af0574da035ee296803d8d5f97ef79L29-R39
Maybe because we didn't fall in the lld case, but I think OSX should fall in this case so we should have seen it in the next PR #2063 when trying to build, but can't see it trying to apply it https://travis-ci.org/kivy/python-for-android/jobs/651206650
[INFO]: Applying patches for python3[armeabi-v7a]
[INFO]: Applying patch patches/py3.8.1.patch
So this lld case is not covered by our CI
Member
|
We could also have renamed the patch file itself to keep its name explicit as it's actually removing the cortex flag. But I think this is equally fine, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed description of patch's name to apply correctly