added a recipe for bcrypt library#2035
Conversation
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Nice, this looking good to me overall. I only have two requests.
- reverting all the changes from the README.md
- squashing your changes
If you really struggle with the squash we can do it a merge time, but I usually prefer if a small change is squashed rather than spread across 4 commits.
README.md
Outdated
| [](#backers) | ||
| [](#sponsors) | ||
|
|
||
| *Added Bcrypt Recipe* |
There was a problem hiding this comment.
Why are these change in the README.md? Could you revert all changes of it if not needed.
There was a problem hiding this comment.
@AndreMiras I removed the redundant line.
There was a problem hiding this comment.
Thanks, there's still one change in the README.md to revert. Your diff removes one line when it should simply not touch the README.md at all as it brings noise we don't want in the history. Could you fix that one too before we merge?
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks there's one more change left in the README.md that needs to be reverted
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Looking good, thanks for addressing the comments
2 participants
No description provided.