Fix libshine and re-enable it for ffmpeg & ffpyplayer_codecs#2027
Merged
opacam merged 2 commits intokivy:developfrom Nov 24, 2019
Merged
Fix libshine and re-enable it for ffmpeg & ffpyplayer_codecs#2027opacam merged 2 commits intokivy:developfrom
opacam merged 2 commits intokivy:developfrom
Conversation
- make it build as shared - move to python3's f-strings - fix linking when building the shared library
Member
Author
|
I merged this because we have confirmation, via discord channel, that this PR solves the runtime problem mentioned at the first post. @misl6 ❤️, ¡¡¡Thanks for the testing!!! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the recent fix for the ffmpeg recipe #1997, we detected that the libshine recipe wasn't working properly at runtime (libavcodec complains about missing symbols), so here we have the fix for that.
In here we:
I tested the build for archs:
armeabi-v7aandarm64-v8a...both builds succeed. Also checked the symbols via commandreadelf -a libshine.soand it seems that the missing func is in there, see 264:Also checked the libabcodec.so library with
readelf -d libavcodec.so:It seem that libshine is linked to it as a shared library, so I think that the errors described at #1997 should not happen anymore...hope that we don't have any other error 🤞
I think that this PR should solve the ffmpeg problem with libshine, but I cannot test it runtime, so it would be great that someone could test it at runtime...
Note: Aaa...my terminal throws the messages with a mix of languages (Catalan, french and english)...I'm guessing that the debian translations are not good enough for catalan :<, anyway, in order to not alter the terminal output, here I give the relevant translations from catalan to english: