Fix error on py2 when import numpy#2003
Merged
AndreMiras merged 1 commit intokivy:developfrom Oct 15, 2019
Merged
Conversation
Also: - make use of python3 `super()` for numpy recipe
AndreMiras
approved these changes
Oct 14, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, thanks
Even though it often hurts me to see time/effort spent on Python2 specific. That actually deserves a won't fix to incentive users to move to target Python3 as well
Member
Author
|
Aaa.. you are right @AndreMiras, people should move to python3, but we still have python2 in here, so I have the feeling that we should give a solution, or we will fill p4a issues about the same error, anyway feel free to merge this yourself or close it I give this to your judgement 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
super()for numpy recipeCloses: #1988