Added missing recommendations command and cleaned up code#1975
Added missing recommendations command and cleaned up code#1975inclement merged 7 commits intokivy:developfrom
Conversation
This should have been the original value, agreed in kivy#1918
|
Also updated minimum python version supported to 3.6, as originally agreed in #1918 - it's my mistake that I left it at 3.4 in that PR. This minimum version is now essential since I added f-strings to the code. |
AndreMiras
left a comment
There was a problem hiding this comment.
Looking good thanks, except the linter is crying
|
This one is also failing only on osx with the pyconfig.h error...not sure what's wrong, although it seems fairly clear this PR is not the culprit. |
|
Tests failing only due to macos issue also present on trunk. |
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM!
And I got mislead in the other PR thinking it was the one breaking osx with python3.8, but definitely not then
|
Thanks! |
|
For records, this got fixed recently via #2063 |
Added this missing command, which existed in the argument parser but wasn't actually implemented.
Not sure what format we really want, but just having the command available is probably an improvement for now.
I thought about removing the argument entirely, but it does seem useful to be able to print the p4a recommendations easily.