Fix crash when guessing Bootstrap (expand_dependencies)#1914
Merged
AndreMiras merged 1 commit intokivy:developfrom Jul 10, 2019
Merged
Fix crash when guessing Bootstrap (expand_dependencies)#1914AndreMiras merged 1 commit intokivy:developfrom
AndreMiras merged 1 commit intokivy:developfrom
Conversation
When a pure python package it's supplied inside the dependency list (for the method `expand_dependencies`), we will get a crash because we don't have a recipe for it, unless we contemplate that situation
AndreMiras
approved these changes
Jul 10, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for catching-fixing-testing it
|
Oopsie, did I break things again 😬 😬 😬 the fix looks exactly like I would have done it, so good work ❤️ and sorry 😂 Edit: for what it's worth if anyone is curious, I think I didn't catch this because while I built my super complex app to test, I use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pure python package it's supplied inside the dependency list (for the method
expand_dependencies), we will get a crash because we don't have a recipe for it, unless we contemplate that situationNote: We missed that because we haven't a pure python package in our CI` builds for the testapps
As a side note: The
expand_dependenciesmethod was recently introduced in PR #1887