Remove legacy version of openssl#1870
Merged
AndreMiras merged 1 commit intokivy:developfrom Jun 17, 2019
Merged
Conversation
Because we introduce the legacy version of openssl to made it work `python2legacy`, but we recently removed `python2legacy`, so there is no point to maintain this changes. Also: - we shortens some lines to be friendly with pep8 - removed comment about ndk-r15c because our minimal ndk is r17c, so this comment is now pointless Note: the python3crystax recipe make use of this legacy openssl libs, but, as far as I know, nobody is maintaining the python3crystax recipe (probably is broken and we should remove it)
7 tasks
AndreMiras
approved these changes
Jun 17, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Indeed this was introduced in #1537 for transitioning.
Happy to see it goes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we introduce the legacy version of openssl to made it work
python2legacy, but we recently removedpython2legacy, so there is no point to maintain this changes.Also:
Note: the python3crystax recipe make use of this legacy openssl libs, but, as far as I know, nobody is maintaining the python3crystax recipe (probably is broken and we should remove it)