Merged
Conversation
So we can test Pillow and some of the libraries that Pillow depends on (freetype, harfbuzz, jpeg and png)
AndreMiras
approved these changes
May 28, 2019
Member
AndreMiras
left a comment
There was a problem hiding this comment.
Nice thanks.
I think we should start thinking about a more conventional unit test like architecture
Member
Author
|
Oh yes, totally agree...but where to start? Implementing all the |
Member
|
Yes kinda the idea indeed. There's no urge, but we should think about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can test Pillow and some of the libraries that Pillow depends on (freetype, harfbuzz, jpeg and png)
Some notes:
testappto test Rework of freetype/harfbuzz recipes #1825Piloperations performed in here are done with *.png images...but it could be enhanced to include some other tests with *.jpegimport ctypesandtest vibration) but this last one will only work on Android Oreo +. This also applies to all other tests that we trigger the android's vibration and this is happening becausevibratewas deprecated in API level 26. Since I still haven't the solution for this I put atodoas a reminder and wrote in here (maybe we should create a new issue about this...)Also see: https://developer.android.com/reference/android/os/Vibrator
As a side note: I don't know if we should include this testapp in the master branch...whatever the team decide it's fine to me...but I wanted to share it so we could test the changes applied in the mentioned pr...so if anyone feels that we shouldn't merge this let me know or directly close it, no problem 😉