Start service with start foregroundService on Android Oreo#1786
Start service with start foregroundService on Android Oreo#1786brvier wants to merge 3 commits intokivy:developfrom
Conversation
…ification channel for Oreo permanent service notification kivy#1785
|
Yes we are |
|
Thanks @brvier, the changes look basically good to me. It looks like travis is complaining about a build issue though, is this a real problem with the code? |
| @Override | ||
| public int startType() { | ||
| return START_STICKY; | ||
| return START_NOT_STICKY; |
There was a problem hiding this comment.
I'm really not getting that part 🤔 we have the if sticky in the template, but we decide to return not sticky.
There's something fishy about it no?
|
@inclement @brvier I think usually the CI fails for good reasons. Here for instance we have: |
pythonforandroid/bootstraps/common/build/templates/Service.tmpl.java
Outdated
Show resolved
Hide resolved
Hopefully, else it s useless. So here Travis point to dependancies i have, and which isn't default on pythonforandroid. Is there any problem to add this deps in pythonforandroid ? |
|
Yes if your pull request requires a dependency, then yes add that dep as part of your pull request and also think about about updating the docs in that same PR |
|
Is this superseded now and possibly should be closed? @inclement & @AndreMiras I'm seeing similar code already in current |
|
Since we seem to have something similar on If anyone thinks this is closed by mistake let me know and I'll gladly immediately reopen |
And add a notification channel for Oreo permanent service notification
Fix #1785