[protobuf_cpp] fixed runtime issues#1757
Merged
AndreMiras merged 1 commit intokivy:masterfrom Mar 16, 2019
Merged
Conversation
two issues were causing troubles with protobuf during runtime: - a missing `__init__.py` in site-packages/google was preventing to import the lib (at least with Python 2) - the links options (`-l …`) where not taken into account. By moving them to LDFLAGS it works correctly.
Member
|
Thanks for the PR I'd like to test it at runtime at least on Python3 before merging |
Member
|
I gave it a try prior the fix. With the following import code: And I got the following runtime error: |
AndreMiras
approved these changes
Mar 16, 2019
Member
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks!
I've tested the fix on Python3 target and I confirm the linker flags update also fixes the runtime on Python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two issues were causing troubles with protobuf during runtime:
__init__.pyin site-packages/google was preventing to import the lib (at least with Python 2)-l …) where not taken into account. By movingthem to LDFLAGS it works correctly.