Requests runtime permissions list, fixes #1704#1741
Conversation
|
Tested with: request_permissions([Permission.CAMERA, Permission.WRITE_EXTERNAL_STORAGE])As we can see in the attached screenshot (:es: sorry), it did popup a page with two permission requests.
|
|
Looks good and backwards compatible 👍 do you want me to test it as well with my app? |
|
Thanks @Jonast for the review. Yes feel free to test it. Keep in mind it requires pyjnius update otherwise it would crash |
There was a problem hiding this comment.
Changes look reasonable, and I've verified with my own non-trivial app that requests sd card permissions that backwards compatibility with an old unaware app using the old call isn't broken 👍 (I runtime tested on an android device by going through the dialog and it worked as before)
|
@AndreMiras oh huh I am just thinking, the docs example might also need an update, right? the one given here: https://github.com/kivy/python-for-android/blob/master/doc/source/apis.rst#runtime-permissions |
Matches the official Android API via, making it possible to request multiple runtime permissions at once. Keeps the previous `android.permissions.request_permission()` interface for compatibility. Bumps pyjnius to post 1.2.0 release that solves required method resolution issues. On 1.2.0, the error was: ``` jnius.jnius.JavaException: No methods matching your arguments, available: [] ```
AndreMiras
force-pushed
the
feature/ticket1704_request_permissions
branch
from
4976f18 to
2ea377e
Compare
|
Thanks @Jonast for the review and the heads-up, I've updated the PR with the documentation changes |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks good! (including docs changes) 👍
1 participant
Matches the official Android API via, making it possible to request
multiple runtime permissions at once.
Keeps the previous
android.permissions.request_permission()interfacefor compatibility.
Bumps pyjnius to post 1.2.0 release that solves required method
resolution issues. On 1.2.0, the error was: