Added warning for arguments containing carriage returns. This happens…#1712
Merged
AndreMiras merged 2 commits intokivy:masterfrom Feb 18, 2019
Merged
Added warning for arguments containing carriage returns. This happens…#1712AndreMiras merged 2 commits intokivy:masterfrom
AndreMiras merged 2 commits intokivy:masterfrom
Conversation
… if a shell script was written in Windows but executed in Linux, as may be the case with bash for Windows.
AndreMiras
reviewed
Feb 17, 2019
AndreMiras
previously approved these changes
Feb 17, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for trying to save developers time 😄
I made a comment for using format() but it's minor so merging anyway.
Maybe for later contributions you should take a look at the 50/72 formatting rule for your commits
AndreMiras
reviewed
Feb 17, 2019
Contributor
Author
|
Thank you for your comments Andre, and also for telling me about the 50/72 rule. I'm going to start using that at work! |
AndreMiras
approved these changes
Feb 18, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for the PR and for addressing the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… if a shell script was written in Windows but executed in Linux, as may be the case with bash for Windows.
Example of undefined behaviour:
--requirements=python3,kivy,numpy, which causes the last package to benumpy\rdue to the CRLF at the end of the line. This might get through to pip but not have any associated p4a recipes, leading to many red herrings and wild goose chases.The solution to this was straightforward (change my text editor to use LF instad of CRLF), but this behaviour was difficult and time-consuming to debug. Although this problem is not due to python-for-android, I decided to open this PR regardless as it would improve developer quality of life.