Merged
Conversation
Member
Author
|
Travis conditional build happy: See https://travis-ci.org/kivy/python-for-android/jobs/491224312 for detailed build log |
opacam
approved these changes
Feb 10, 2019
Member
opacam
left a comment
There was a problem hiding this comment.
Great, I like it 😄, also seems that travis is happy so...
¡¡¡Thanks @AndreMiras!!!
opacam
reviewed
Feb 10, 2019
|
|
||
|
|
||
| class PyLevelDBRecipe(CompiledComponentsPythonRecipe): | ||
| class PyLevelDBRecipe(CppCompiledComponentsPythonRecipe): |
Member
There was a problem hiding this comment.
As a side note: That is my biggest concern, because we make dependant of gnustl_shared (which, as far as I know, is Deprecated in ndk r18)...so all recipes that depend on gnustl_shared will fail with newer ndks...but ,we have all relevant code concentrated in CppCompiledComponentsPythonRecipe 😉
Related to: Support for NDK 19 (#1613)
See also: https://developer.android.com/ndk/guides/cpp-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.