Merged
Conversation
AndreMiras
commented
Feb 4, 2019
AndreMiras
commented
Feb 4, 2019
- F841 local variable ... is assigned to but never used - F812 list comprehension redefines ... Also added pyleveldb recipe to list of broken recipes, the error was: ``` /home/user/.local/share/python-for-android/build/other_builds/hostpython2/desktop/hostpython2/Include/Python.h:47:19: fatal error: crypt.h: No such file or directory ``` See https://api.travis-ci.org/v3/job/488398065/log.txt
AndreMiras
force-pushed
the
feature/tox_update_and_linter_fixes
branch
from
1014eb9 to
b54a1d0
Compare
Member
Author
|
Build eventually green https://travis-ci.org/kivy/python-for-android/builds/488417097 @inclement could you review/merge? |
opacam
reviewed
Feb 4, 2019
KeyWeeUsr
approved these changes
Feb 4, 2019
Contributor
KeyWeeUsr
left a comment
KeyWeeUsr
left a comment
There was a problem hiding this comment.
Check via grep or something that the parser variables (add_parser() result) are not imported somewhere else, otherwise it seems ok. 👍
Member
Author
|
Thanks for the review guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added pyleveldb recipe to list of broken recipes, the error was:
See https://api.travis-ci.org/v3/job/488398065/log.txt