Fix various issues with graphs and recipes#1669
Merged
Conversation
ghost
changed the title
AndreMiras
reviewed
Feb 3, 2019
Member
|
Thanks for making a dedicated one for it. We'll review it more seriously later on. |
AndreMiras
reviewed
Feb 3, 2019
Author
|
@AndreMiras thanks I had to fix some of the unit tests, it should work now! |
AndreMiras
reviewed
Feb 3, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
KeyWeeUsr
suggested changes
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 4, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for the PR @Jonast it looks once again very good overall! 💪
I left some minor comments and less minor concerns, please let me know what you think.
I think we're almost there, just I prefer to be sure the code looks great since we're touching sensitive components
KeyWeeUsr
reviewed
Feb 4, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
reviewed
Feb 5, 2019
AndreMiras
previously approved these changes
Feb 5, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
I'm ready for the merge, thanks for your time and effort 💪
Will merge when build turns green
- fix graph depending on capitalization when pip doesn't - fix graph giving no useful errors (now it gives them sometimes) - fix graph entering infinite loop when no bootstrap is found - fix recipe not being obtainable irregardless of capitalization - fix recipe IOError-on-doesn't-exist not distinguishable from code-messes-up-and-causes-true-IOError. a non-existent recipe will now cause a ValueError - fix the bootstraps own dependencies being wrong and unused - possibly other minor fixes I forgot about
ghost
dismissed
KeyWeeUsr
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recipe-exists-but-code-messes-up-and-causes-unintentional-IOError.
a non-existent recipe will now cause a ValueError
python2+sdl2topython3+sdl2(some of these fixes are required for #1625 / project's
setup.pyto be reasonably used)