Speed up Python and NumPy compilation process#1651
Merged
inclement merged 1 commit intokivy:masterfrom Feb 1, 2019
Merged
Conversation
AndreMiras
force-pushed
the
feature/python_build_parallel_jobs
branch
from
cc379cd to
79d23ed
Compare
KeyWeeUsr
reviewed
Feb 1, 2019
Uses `-j` flag on target/host python as well as numpy to run compilation in parallel. In NumPy we need to revert the `setup_extra_args` value so it doesn't mess up with subsequent calls, e.g. `python setup.py install`.
AndreMiras
force-pushed
the
feature/python_build_parallel_jobs
branch
from
79d23ed to
b4a6a66
Compare
AndreMiras
commented
Feb 1, 2019
Member
Author
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
I've updated the PR with explicit jobs count via cpu_count()
KeyWeeUsr
approved these changes
Feb 1, 2019
inclement
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
-jflag on target/host python as well as numpy to run compilationin parallel. In Python an optimum number of jobs is guessed if the flag
is used alone. In NumPy it must be explicitly set.