Skip to content

Made the activity launch mode default to singleTask#1646

Merged
AndreMiras merged 1 commit intokivy:masterfrom
inclement:use_singleTask_launchMode
Jan 31, 2019
Merged

Made the activity launch mode default to singleTask#1646
AndreMiras merged 1 commit intokivy:masterfrom
inclement:use_singleTask_launchMode

Conversation

@inclement
Copy link
Member

Fixes #1271.

Using singleTask seems appropriate to make sure that our activity is not recreated, so new intents are passed to the existing activity if possible. Doc at https://developer.android.com/guide/topics/manifest/activity-element.

@inclement inclement requested a review from AndreMiras January 31, 2019 20:45
@inclement
Copy link
Member Author

@AndreMiras Can you approve this? Although the tests failed due to flakiness, it doesn't touch anything that should affect the tests (unless some trivial syntax error).

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AndreMiras AndreMiras merged commit 603f8d9 into kivy:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants