Skip to content

Set $LANG in PythonRecipe#1642

Merged
inclement merged 1 commit intokivy:masterfrom
inclement:set_LANG_in_python_recipe
Jan 31, 2019
Merged

Set $LANG in PythonRecipe#1642
inclement merged 1 commit intokivy:masterfrom
inclement:set_LANG_in_python_recipe

Conversation

@inclement
Copy link
Member

Seems pretty benign so no reason not to do it.

Fixes #703.

@inclement inclement requested a review from AndreMiras January 31, 2019 17:12

# Set the LANG, this isn't usually important but is a better default
# as it occasionally matters how Python e.g. reads files
env['LANG'] = "en_GB.UTF-8"
Copy link
Member

@AndreMiras AndreMiras Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not en_US.UTF-8 :trollface:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually copied it from #703 and didn't even read it :p

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge once Travis is happy

@inclement inclement merged commit 2cc008b into kivy:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants