Added separate module for checking user SDK, NDK, API etc.#1640
Merged
AndreMiras merged 4 commits intokivy:masterfrom Jan 31, 2019
Merged
Added separate module for checking user SDK, NDK, API etc.#1640AndreMiras merged 4 commits intokivy:masterfrom
AndreMiras merged 4 commits intokivy:masterfrom
Conversation
Also fixed some issues found during testing
inclement
force-pushed
the
improve_ndk_version_check
branch
from
b4f8bdd to
caf4714
Compare
inclement
force-pushed
the
improve_ndk_version_check
branch
from
caf4714 to
bd0a47c
Compare
inclement
force-pushed
the
improve_ndk_version_check
branch
from
bd0a47c to
7630222
Compare
inclement
force-pushed
the
improve_ndk_version_check
branch
from
9c49f5d to
5400761
Compare
AndreMiras
previously approved these changes
Jan 31, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Oh man I absolutely love it, nice refactoring!
Also it would really simplify if we want to unit test some parts separately.
Let's make sure Travis is happy before we merge.
Closed
I don't think this kind of change is a good one for the ci to catch, the original comment structure was fine.
Member
Author
|
@AndreMiras Can you approve again and merge? One test failed only due to travis flakiness, the code changes seem fine. |
AndreMiras
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the ndk version check (the user parameter is removed entirely as it has no purpose), and moved various different checks into their own functions in a new recommendations module. This should make it simpler to update p4a's warnings and recommendations in the future.
Also fixed a few bugs found while testing.