Fixes ifaddrs recipe, closes #1398#1633
Merged
inclement merged 1 commit intokivy:masterfrom Jan 30, 2019
Merged
Conversation
AndreMiras
force-pushed
the
feature/ticket1398_ifaddrs_fixes
branch
from
cc6870d to
393b588
Compare
Member
|
Looks like the changed-recipes travis build failed due to trying to cp into a directory that doesn't exist. Is that a problem with the PR? |
Member
Author
|
Yes actually now the recipe passes the compilation phase, but not copying the library over. |
- makes sure the compiler is being used rather than ccache alone - pin the commit version and use zip download rather than git clone - do not manually copy over lib and header files
AndreMiras
force-pushed
the
feature/ticket1398_ifaddrs_fixes
branch
from
393b588 to
91a55aa
Compare
inclement
approved these changes
Jan 30, 2019
Member
|
++ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure the compiler is being used rather than ccache alone.
Also pin the commit version and use zip download rather than git clone.