Create a dumb librt recipe and refactor the affected recipes to make use of this#1618
Create a dumb librt recipe and refactor the affected recipes to make use of this#1618AndreMiras merged 1 commit intokivy:masterfrom
dumb librt recipe and refactor the affected recipes to make use of this#1618Conversation
…e use of this Because some recipes inserts flags without our control (`-lrt`) and this is a problem because librt does not exist in android, but has been integrated into libc, so, this recipe create a temporary symbolic link from libc to librt so the compilation can find the necessary `symbols/functions` to finish the compilation Note: Once we end the build we will remove the created symbolic link
|
I see that fails on create the link (permission error)... This was not happening with non docker tests... |
|
Aaaa...I see: It's the same error: The problem in here is that if a user has installed the ndk in some directory as a root user, he will get this error if he runs the p4a command as a regular user... Maybe we should reproduce in the docker what a user would do? |
AndreMiras
left a comment
There was a problem hiding this comment.
Awesome ❤️
As for the Docker environment, I agree, we should discuss/tackle in a dedicated task
|
@opacam @AndreMiras this appears to break build for me: #1621 |
|
Oops, seems like this was broken before. I just never tried |
|
@Jonast, I have a solution for docker, still not created a pr, but I will, don't worry ;) |
|
@Jonast, If you are in hurry with this I will do it now...do you need that? |
|
@opacam take your time it's not urgent. |
|
Here it is the commit that will solve the docker issue with I will create the pr as soon as I have the explanations (I only move code in there, from one place to another, except for the variable |
|
@opacam did you just make the NDK folder writable? Because I would not consider that a fix to this, I think the problem is that it is assumed to be writable in the first place. The fault is IMHO definitely with the |
|
No, I change the download directory into a user directory |
|
Which has the same outcome really. You are changing it from a system-wide to a user install to make it writable - this shouldn't be required, and isn't required for any other recipe. In my eyes that's a workaround hack, not a fix 🤷♂️ not that I don't think that's not possibly useful for other reasons, but I don't think this should be required to be able to build |
|
(as a side note I don't use that docker container anyway, so this wouldn't fix anything for me) |
|
yes I do would prefer that we make it work just like other recipes. So adding build artifact to a dedicated recipe build folder and then link it via |
Because some recipes inserts flags without our control (
-lrt) and this is a problem because librt does not exist in android, but has been integrated into libc, so, this recipe create a temporary symbolic link from libc to librt so the compilation can find the necessarysymbols/functionsto finish the compilationNote: Once we end the build we will remove the created symbolic link
¡¡¡Thanks @AndreMiras, for this idea of "dumb" librt recipe!!!