Fix libffi/ctypes - wrong libffi headers when building python#1609
Merged
inclement merged 4 commits intokivy:masterfrom Jan 26, 2019
Merged
Fix libffi/ctypes - wrong libffi headers when building python#1609inclement merged 4 commits intokivy:masterfrom
inclement merged 4 commits intokivy:masterfrom
Conversation
To simplify the linkage of the libffi library (with this we will know exactly where will be built libffi files before the build happens)
Because the python3's recipe uses pkg-config to link with the libffi library, and pkg-config reads the libffi.pc file which does not have the right values for us because we never performed the install for the libffi recipe. With this, we will make sure that the libffi.pc files has the standard header values so the python build could make use of it and explicitly link with our library.
To make sure that python links explicitly with our library Note: This should solve the ctypes error reported by some users caused because python gets built with a wrong libffi library
…quirements This is only necessary for python2 because in python3 the configure option that we use in python2 has been removed
|
👍 this looks like the more comprehensive solution that avoids unnecessary patches to the project itself. While it appears to add a little complexity, it is limited to the libffi-recipe and I personally think this approach is the better one (not to say that @tito 's solution is bad or anything) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been reported of errors with
ctypes, even when thectypesmodule seems to be built fine.@tito is one of the affected by this and he found that, in some system configuration, python could be:
compiled with the headers of the system libffi, but runs with the target libffiThat will end in an app crash...
So...this pr makes that the python build make use of our libffi headers.
This would be a third solution to add to the ones proposed by @tito in #1605
This solution avoids to patch python3 and will also work for python2
!!!So many thanks @tito to found where the problem started 😄!!!