Fix getting empty "modules" directory when arch is not armeabi-v7a#1608
Merged
AndreMiras merged 1 commit intokivy:masterfrom Jan 25, 2019
Merged
Fix getting empty "modules" directory when arch is not armeabi-v7a#1608AndreMiras merged 1 commit intokivy:masterfrom
AndreMiras merged 1 commit intokivy:masterfrom
Conversation
…n arch is other than armeabi-v7a
AndreMiras
approved these changes
Jan 25, 2019
Member
AndreMiras
left a comment
There was a problem hiding this comment.
One hardcoded arm less, well done!
It looks good even though playing with the command_prefix string feels a bit hacky, I didn't see what else we could use.
I've restart the build that was flaky and will merge if it goes green.
Thanks!
Member
|
Merged thanks! |
Contributor
Author
|
Thanks!
Indeed. In future, if this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
create_python_bundle(), copy source path of built modules (*.so) is hardcoded toarm. This results in an emptymodulesdirectory when buildarchis other thanarmeabi-v7a.This PR fixes the above issue; accordingly, the
modulesdirectory is generated as expected (when arch isx86,x86_64,arm64-v8a, etc).