Fix --private and others showing weird error when used without argument#1591
Conversation
ghost
mentioned this pull request
|
Very good!!! @Jonast , thank you ! checked in added link |
inclement
approved these changes
Jan 26, 2019
Member
inclement
left a comment
inclement
left a comment
There was a problem hiding this comment.
I guess I also missed that this should really also check if the i+1th entry is also an argument (starting with - or --) before converting it to a path.
Author
|
@inclement argparse supports |
Member
|
@Jonast Sure, it's not that we need to reinvent the argparse logic so much as that it would probably improve more errors than it makes worse. |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using some of the options like
--privatewithout an argument, which shouldn't be done but users make mistakes sometimes, this currently causes a weird backtrace error that isn't obvious to the average user. This pull request addresses that problem such that better error handling can happen