Skip to content

[CORE FIX/ENHANCEMENT] Speedup copy that can be very very long (up to 2 minutes)#1585

Merged
KeyWeeUsr merged 2 commits intokivy:masterfrom
opacam:fix-slow-copy
Jan 13, 2019
Merged

[CORE FIX/ENHANCEMENT] Speedup copy that can be very very long (up to 2 minutes)#1585
KeyWeeUsr merged 2 commits intokivy:masterfrom
opacam:fix-slow-copy

Conversation

@opacam
Copy link
Member

@opacam opacam commented Jan 12, 2019

This fixes the slow copy issue we have when copying files to our distribution folder and affects to python2 and python3.

I tested this in python 3 and @tito made and tested this commit in his own builds for python 2. Travis will say the final words but I suspect that we can reduce travis's build timings...will see...

@inclement please...take a look on this when you have time...this affects the core!

Again 😄, ¡¡¡Thanks @tito!!!

Copy link
Contributor

@KeyWeeUsr KeyWeeUsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it seems like there is no speed bumping when doing list(<list>) even with large lists I still don't think it's necessary to wrap lists with unnecessary call.

Also, good job, it saves about 3-4 minutes on travis! :)

@KeyWeeUsr KeyWeeUsr merged commit 6735c6f into kivy:master Jan 13, 2019
@opacam
Copy link
Member Author

opacam commented Jan 13, 2019

¡¡¡Thanks to merge this one @KeyWeeUsr, that will save time for all of us ❤️!!!

¡¡¡And also thanks to @tito ❤️ wich made this, all the credits for him...I'm only the messanger 😄!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants