[WIP] Rework zbar (add python3 compatibility + add recipes: pyzbar and zbarlight)#1583
Merged
AndreMiras merged 3 commits intokivy:masterfrom Jan 21, 2019
Merged
[WIP] Rework zbar (add python3 compatibility + add recipes: pyzbar and zbarlight)#1583AndreMiras merged 3 commits intokivy:masterfrom
AndreMiras merged 3 commits intokivy:masterfrom
Conversation
The python headers are set in the method get_recipe_env of PythonRecipe's base class, so there is no need to set the python headers. Also make sure that we can build with python2legacy. Also move libraries from LDFLAGS TO LIBS.
The libzbar recipe contains some flags already set in base class method of get_recipe_env, so removed. Also grants python3 compatibility for libzbar because, despite that the zbar recipe isn't compatible with python3 (the project is stucked in python2 plus it seems unmaintained)...but there are alternatives which can replace it, so we add the pyzbar recipe which works for both versions of python so python3 will have an equivalent to the python2's zbar. Also moved libraries from LDFLAGS to LIBS.
Member
|
Looking overall good to me, why is it a |
Member
Author
|
Because I only tested the build of those recipes. I usually modify some app and try to import and make some calls...but in this case I hadn't got time for that...it seems to build fine, the packages are installed where they should be...it should work...but not properly tested... |
AndreMiras
approved these changes
Jan 21, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Better than the current state where it didn't even compile for python3. Will create issue/PR if we get runtime issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this should be properly tested with some application using this recipes, I only tested the build for python 2 and python 3...so...any feedback about this will be great...