[WIP] Rework libxml2, libxslt and lxml (update versions)#1580
[WIP] Rework libxml2, libxslt and lxml (update versions)#1580AndreMiras merged 3 commits intokivy:masterfrom
Conversation
Actions taken: - replace double quotes to single quotes because I think that it's more readable - fixed imports - shortened lines
Actions taken: - replace double quotes to single quotes because I think that it's more readable - fixed imports - fix hardcoded entries
Actions taken: - replace double quotes to single quotes because I think that it's more readable - fixed imports - shortened lines
|
Looking overall good to me. Let's see if Travis is happy about it. |
|
Yes, you are right @AndreMiras, it's a personal taste the quotes 😬 (I knew before hand that this will be problematic 😏...if you want I will change to double quotes no problem). Anyway, as far as I know, it is recommended to be consistent along all the project, and now we have mixed quotes and before the change I checked some of the core modules and it seemed to me that single quotes are predominant...but I cannot be sure about that...so...the said...just tell me and I will change it . |
| super(LXMLRecipe, self).build_compiled_components(arch) | ||
|
|
||
| shprint(sh.rm, '-r', link_rt + '.so') | ||
| shprint(sh.rm, '-r', link_rt + '.a') |
|
I usually tend not to switch from one to the other as it adds noise to the diff and makes reviewing a more difficult. But I would not go as far as asking to revert 😄 Anyway looking good overall, thanks! Edit: oops I didn't squash 😬 |
|
I'm having trouble building libxml2 , there is no file libxml2.* in the APK Re installed p4a from master today Looking in recipes/libxml2/init.py it seems the .a is explicitly not created, then copied elsewhere! Can you please help me see what I am missing? Using: .p4a: Log file: |
The lxml recipe depends on those two libraries, if we update lxml we must update the two libraries (libxml2 and libxslt). This rework takes care of that and also:
Note: Successfully build for python3 and python2 (tested some days ago in a real python3's app but it would be great that someone could test it again)