Skip to content

Fix incorrect call assuming that OS python minor version matches hostpython#1577

Merged
AndreMiras merged 1 commit intomasterfrom
unknown repository
Jan 12, 2019
Merged

Fix incorrect call assuming that OS python minor version matches hostpython#1577
AndreMiras merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 10, 2019

This fixes a call which makes the incorrect assumption that OS python minor version matches the hostpython's minor version. (which will lead to a build error/crash/backtrace when the minor versions differ, as e.g. described here: https://github.com/JonasT/p4a-build-spaces/issues/4 )

Edit: tested now, works fine for me! would recommend merging

@ghost ghost changed the title [WIP] Fix incorrect assumption that OS python minor version matches hostpython Fix incorrect assumption that OS python minor version matches hostpython Jan 10, 2019
@ghost ghost changed the title Fix incorrect assumption that OS python minor version matches hostpython Fix incorrect call assuming that OS python minor version matches hostpython Jan 11, 2019
@homdx
Copy link

homdx commented Jan 11, 2019

@Jonast

  1. You can release feature in p4a-build-spaces,
    like ./p4a-build-spaces --list
    for show avialibly variables (list folders):
    https://github.com/JonasT/p4a-build-spaces/tree/master/src/p4aspaces/environments

  2. How I use Another branch and repository for python-for-android wth p4a-build-spaces?
    Maybe, also, you add feature like this: ( or otherwise - depending on your choice):
    ./p4-build-spaces --build-args P4A_REPO=JonasT --build-args P4A_BRANCH=fixbuildpythoncall shell p4a-py3-api28ndk21

@ghost
Copy link
Author

ghost commented Jan 11, 2019

@homdx there is already an option for choosing another p4a version/branch, it works like this: --p4a <branchname> (for a github.com/kivy/python-for-android repo branch), or --p4a <full_repo_archive_url> (for a fork/different repo)

Example for the full archive url: --p4a https://github.com/forkinguser/python-for-android/archive/branchname.zip.

For this particular pull request, use --p4a https://github.com/JonasT/python-for-android/archive/fixbuildpythoncall.zip

@homdx
Copy link

homdx commented Jan 11, 2019

About pull request:
Python 2 build:)

[INFO]:    -> running bash -c env CC=/bin/false CXX=/bin/false PYTHONPATH=/root/.local/share/python-for-android/build/python-installs/unnamed_dist_3 venv/bin/pip install --target '/root/.local/share/python-for-...(and 75 more)
[INFO]:    <- directory context /root/pydelhi_mobile/pydelhiconf 

Python3: Also build without error

Reccommended for merge to master)

@homdx
Copy link

homdx commented Jan 11, 2019

@Jonast

  1. You can release feature in p4a-build-spaces,
    like ./p4a-build-spaces --list
    for show avialibly variables (list folders):
    https://github.com/JonasT/p4a-build-spaces/tree/master/src/p4aspaces/environments
    Found))) You realse it:
 ./p4aspaces list-envs
Available environments:
  p4a-py2-api19-ndkbundle
     Python 2 with min/target API 19, bundled NDK 19
  p4a-py2-api28ndk21
     Python 2 with target API 28, bundled NDK 21, min api 21
  p4a-py3-api28ndk21
     Python 3 with target API 28, NDK 21, min api 21
  p4a-py3crystax-api19-ndkbundle
     Python 3 Crystax with min/target API 19, and ndk-bundle for API 19
  p4a-py3crystax-api26ndk19
     Python 3 Crystax with target API 26 and NDK/min api 19

Launch shell with:
  p4aspaces shell p4a-py2-api19-ndkbundle

@homdx
Copy link

homdx commented Jan 11, 2019

@homdx there is already an option for choosing another p4a version/branch, it works like this: --p4a <branchname> (for a github.com/kivy/python-for-android repo branch), or --p4a <full_repo_archive_url> (for a fork/different repo)

Example for the full archive url: --p4a https://github.com/forkinguser/python-for-android/archive/branchname.zip.

For this particular pull request, use --p4a https://github.com/JonasT/python-for-android/archive/fixbuildpythoncall.zip

Need added to command line help:

$ ./p4aspaces --arguments --help
usage: p4aspaces [-h] action ...

positional arguments:
  action      The p4a-build-spaces action out of "cmd", "list-envs", "shell"
  arguments   The arguments to the action. Use "p4aspaces <action> --help" to
              see available arguments and options for an action.

optional arguments:
  -h, --help  show this help message and exit
$ ./p4aspaces arguments --help
p4aspaces: error: not a known action: "arguments".
       Available actions are:
        - shell
        - cmd
        - list-envs

@ghost
Copy link
Author

ghost commented Jan 11, 2019

@homdx you need to insert the respective action, e.g. p4aspaces cmd --help

@homdx
Copy link

homdx commented Jan 11, 2019

@homdx you need to insert the respective action, e.g. p4aspaces cmd --help

But this instruction are missing:

Example for the full archive url: --p4a https://github.com/forkinguser/python-for-android/archive/branchname.zip.

For this particular pull request, use --p4a https://github.com/JonasT/python-for-android/archive/fixbuildpythoncall.zip

@ghost
Copy link
Author

ghost commented Jan 11, 2019

@homdx good point, I added more details to the help texts now 👍

@AndreMiras AndreMiras merged commit ba82d8a into kivy:master Jan 12, 2019
@ghost
Copy link
Author

ghost commented Jan 12, 2019

thanks for merging ❤️ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants