Fix APP_PLATFORM not properly passed in NDKRecipe#1572
Conversation
ghost
changed the title
Author
|
Ok tested & ready for merge! it doesn't actually fix jpeg for NDKAPI 21 (seems to be a fundamental issue with the android libjpeg-turbo fork) but it should fix others, and I verified that the APP_PLATFORM env var is set, and recognized by the make script without a warning that it would be some invalid or unknown platform |
Author
|
The additional pushes you see are just rebases to latest master. I used this during a couple of builds now without any issues 👍 (all python 3 though, no python 2 builds) |
inclement
approved these changes
Jan 13, 2019
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix APP_PLATFORM not properly passed in NDKRecipe. This is needed so certain NDKAPI/--minimum-api values won't lead to build errors with NDK based recipes, e.g. when using NDKAPI=21 with the current
jpegrecipe