Use API 27 as new default for travis & docs#1532
Merged
AndreMiras merged 1 commit intomasterfrom Dec 16, 2018
unknown repository
Merged
Use API 27 as new default for travis & docs#1532AndreMiras merged 1 commit intomasterfrom unknown repository
AndreMiras merged 1 commit intomasterfrom
unknown repository
Conversation
AndreMiras
reviewed
Dec 15, 2018
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
I know this is a WIP, but here's my two cents.
It looks like the setup_testapp_python3 is already running ont that API 27 right?
But I also like to have it explicitly overridden in the CI so that's fine.
Also wondering if maybe we should use a global env variable just like ANDROID_NDK_HOME so it's clearly defined in one common place.
What do you think?
ghost
changed the title
Author
|
Good point, I properly bumped the actual test files, and also the introduction docs! I think it's actually better to have the environment setup in the test files rather than the |
ghost
changed the title
Use API 27 as default for travis & examples, including `armeabi-v7a` as arch default. 26 is new absolute minimum of the Play Store, and otherwise the new SDL2 2.0.9 pull request won't build.
AndreMiras
approved these changes
Dec 16, 2018
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use API 27 as default for travis & examples, including
armeabi-v7aas arch default.26 is new absolute minimum of the Play Store, and otherwise the new SDL2 2.0.9 pull request won't build.