Unify configChanges manifest entry and add missing values#1522
Merged
AndreMiras merged 1 commit intomasterfrom Dec 15, 2018
unknown repository
Merged
Unify configChanges manifest entry and add missing values#1522AndreMiras merged 1 commit intomasterfrom unknown repository
AndreMiras merged 1 commit intomasterfrom
unknown repository
Conversation
ghost
mentioned this pull request
ghost
changed the title
Author
|
Worked fine for my app! More testing & merging welcome! |
ghost
mentioned this pull request
8 tasks
AndreMiras
approved these changes
Dec 15, 2018
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
It looks good on paper. I've tried sdl2 and as you stated the side by side is not yet working, but the app seems fine.
Thanks!
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current manifests don't specify some values in configChanges, e.g. the ones relevant for the side-by-side feature of new Android versions. If these values are missing, the SDLActivity will be restarted - however, SDL2 as a result will simply quit even when the application is in foreground/active without restarting properly, so the application crashes/instant-quits at any of these events.
In this spirit, the pygame bootstrap also seemed to have a lot more of these values added already, avoiding such config-triggered crashes. But for some reason these weren't in the other bootstraps. I unified the values for all bootstraps, and added the missing ones of newer API levels like
density.Note: to fully get side by side working, we also need #1528 - but with these combined, it works perfectly!