Skip to content

No need to decode into unicode when running in python 3#1512

Merged
AndreMiras merged 1 commit intokivy:masterfrom
jtoledo1974:master
Dec 10, 2018
Merged

No need to decode into unicode when running in python 3#1512
AndreMiras merged 1 commit intokivy:masterfrom
jtoledo1974:master

Conversation

@jtoledo1974
Copy link
Contributor

python-for-android fails to build when running under a python 3 interpreter with the android recipe. There is no decode method in python3 strings.

@AndreMiras
Copy link
Member

Thanks for the pull request @jtoledo1974
It's not the most satisfying approach, but probably the safest one. Also it looks better than what we have now which is broken for host Python3.
Let's see if Travis is happy about it before merging.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on host Python3 and Travis is happy on host python2.

@AndreMiras
Copy link
Member

Merged, thanks for the fix

@KeyWeeUsr
Copy link
Contributor

Ref #1516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants