Remove crystax docker and optimize Dockerfile#1471
Merged
Conversation
KeyWeeUsr
force-pushed
the
remove_crystax_docker
branch
from
58f37e2 to
202ff8a
Compare
KeyWeeUsr
changed the title
KeyWeeUsr
changed the title
KeyWeeUsr
force-pushed
the
remove_crystax_docker
branch
2 times, most recently
from
d03070e to
d0cd82c
Compare
AndreMiras
reviewed
Nov 19, 2018
AndreMiras
reviewed
Nov 19, 2018
AndreMiras
reviewed
Nov 19, 2018
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
So long CrystaX 👋 !
Looking good overall. I just asked a question regarding the environment.
Also I would love if we could s/apt-get/apt/ 🙏
AndreMiras
previously approved these changes
Nov 19, 2018
Prioritize SDK and NDK downloads before everything because once downloaded we don't care about redownloading unless the version is changed and layer cache works this way more efficiently. Redirect Licenses to /dev/null, move more important layers up. Move '&&' operators to the front - Docker sometimes, (personally I've encountered it only with apt and old coreutils), is very critical of the amount of spaces *after* the operator but does not care what's in front of it that much.
KeyWeeUsr
force-pushed
the
remove_crystax_docker
branch
from
d0cd82c to
df60061
Compare
AndreMiras
approved these changes
Nov 19, 2018
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, please make sure the build is green before merging 🙏
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Dec 10, 2018
`python3crystax` support was removed from the CI in kivy#1471. Conditional builds now relies on `python3` with fallback to `python2`. Adds `python3` support to `jedi` recipe to demonstrate.
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Dec 10, 2018
`python3crystax` support was removed from the CI in kivy#1471. Conditional builds now relies on `python3` with fallback to `python2`. Adds `python3` support to `jedi` recipe to demonstrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritize SDK and NDK downloads before everything because once downloaded we don't care about redownloading unless the version is changed and layer cache works this way more efficiently. Redirect Licenses to
/dev/null, move more important layers up. Move&&operators to the front - Docker sometimes, (personally I've encountered it only withaptand oldcoreutils), is very critical of the amount of spaces after the operator but does not care what's in front of it that much.