Closed
Conversation
This is just a preliminary, hacky implementation.
Following tito's patch
(in a temporary hacky way)
Member
|
I agree this is a good improvement, but I worry this could conflict with the soon to be merged #1412 |
Contributor
Author
|
That's fine -- I'll update the patch after #1412 goes in. |
C++ recipe didn't set all instances of `ctx.ndk_dir` in format string
Protobuf has been updated to 3.5.1, it's not the last version (3.6.1) because last version cause trouble during compilation and needs more work. This patch also fixes the issue with hardcoded local path for protoc which could not work. Protobuf needs a version of "protoc" (its compiler, used to produce .py file from .proto files) compiled for the host platform. Official binaries for protoc are available, the recipe will download the one suitable for host and use it. If the platform is not supported, building may still work if the right "protoc" is available in search path.
[protobuf_cpp] Updated to Protobuf 3.5.1 + fixed protoc issue
Python 3 recipe
[cffi] Updated recipe to last cffi version (1.11.5)
Member
|
Hi @dbrnz #1412 just got merged so you can rebase your changes on it. Also just wondering if we could simplify the "wording" further by replacing: info('Found Android API target in $ANDROIDAPI: it is {}'.format(android_api))By directly: info('Found Android API target in $ANDROIDAPI: {}'.format(android_api))So skipping the " |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.