ReportLabRecipe fixes and unit tests, fixes #1380#1383
Merged
AndreMiras merged 1 commit intokivy:masterfrom Sep 30, 2018
Merged
Conversation
AndreMiras
commented
Sep 26, 2018
| info('reportlab recipe: ft_lib_dir={}'.format(ft_lib_dir)) | ||
| info('reportlab recipe: ft_inc_dir={}'.format(ft_inc_dir)) | ||
| with current_directory(recipe_dir): | ||
| sh.ls('-lathr') |
Member
Author
There was a problem hiding this comment.
Removed that "debug" line because I didn't feel like it provided any value.
AndreMiras
commented
Sep 26, 2018
AndreMiras
commented
Sep 30, 2018
tshirtman
previously approved these changes
Sep 30, 2018
Member
tshirtman
left a comment
tshirtman
left a comment
There was a problem hiding this comment.
Just a little nitpick, the rest looks good to me.
- fixes `TypeError` on host Python3 - adds recipe unit test - makes it possible to override `pytest` args via `tox`
AndreMiras
force-pushed
the
feature/ticket1380_unit_test_reportlab_recipe
branch
from
98c9c81 to
dd39888
Compare
tshirtman
approved these changes
Sep 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeErroron host Python3pytestargs viatox