Merged
Conversation
Member
Author
|
I made this recipe ages ago, but I think I found a better way to fix the unicode thing, looking into it. |
Member
|
Looking good to me, I've just added a minor comment |
AndreMiras
previously approved these changes
Nov 11, 2018
| version = '1.1.1' | ||
| url = 'https://github.com/sympy/sympy/releases/download/sympy-{version}/sympy-{version}.tar.gz' | ||
|
|
||
| # depends = [('python2', 'python3crystax'), 'setuptools'] |
Member
There was a problem hiding this comment.
Minor: I think we can drop that commented code
AndreMiras
dismissed
their stale review
Travis is failing with Please install the mpmath package with a version >= 0.19
Member
|
Looks like this is not compiling, Travis fails with: |
Also adds sympy to ignore list: ``` Please install the mpmath package with a version >= 0.19 ```
AndreMiras
force-pushed
the
sympy_recipe
branch
from
9cafea2 to
5f66527
Compare
AndreMiras
approved these changes
Dec 14, 2018
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Fixed linter and added sympy to skip recipe list for the conditional build
|
How can I add Please install the mpmath package with a version >= 0.19 to ignore list? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.