Skip to content

Fix packaging failure when user has large UID by using GNU format over USTAR format#1015

Merged
inclement merged 1 commit intokivy:masterfrom
pts-dorianpula:issue-1013-fix-tarfile-large-user-id-failure
Mar 4, 2017
Merged

Fix packaging failure when user has large UID by using GNU format over USTAR format#1015
inclement merged 1 commit intokivy:masterfrom
pts-dorianpula:issue-1013-fix-tarfile-large-user-id-failure

Conversation

@pts-dorianpula
Copy link

@pts-dorianpula pts-dorianpula commented Feb 24, 2017

Fix for issue #1013

@pts-dorianpula pts-dorianpula changed the title Change to use GNU format over USTAR format, to avoid issues with large user IDs. Fix packaging failure when user has large UID by using GNU format over USTAR format Feb 24, 2017
@inclement
Copy link
Member

Well, seems to work, so let's got for it. Thanks a lot!

@inclement inclement merged commit a56784d into kivy:master Mar 4, 2017
inclement added a commit that referenced this pull request Mar 4, 2017
…arfile-large-user-id-failure"

This reverts commit a56784d, reversing
changes made to b2e5bc3.

The reason for the revert is that although this PR seemed to work, it
actually causes problems with the tar extraction for very long
filenames.
@inclement
Copy link
Member

inclement commented Mar 4, 2017

Unfortunately I found what seems to be a major problem with this shortly after merging, it causes problems when extracting long filenames (at least, I think it's the long filename that's the issue), as in the example below. The files here don't actually need to be there, but it's quite problematic that this could be accidentally triggered.

I've reverted this for now, pending further analysis, hopefully there is some alternative set of options or way to avoid using the uid that we can use.

03-04 22:21:26.267 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/androidjoystick.py
03-04 22:21:26.267 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/linuxwacom.py
03-04 22:21:26.268 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/__init__.py
03-04 22:21:26.268 15657 15684 V python  : extracting crystax_python/site-packages/kivy/input/providers/tuio.py
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/highlight.py
03-04 22:21:26.269 15657 15684 V python  : extracting crystax_python/site-packages/kivy/extras/__init__.py
03-04 22:21:26.270 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/
03-04 22:21:26.271 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/
03-04 22:21:26.271 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.271 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/kinec
03-04 22:21:26.272 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.272 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/kinect/READM
03-04 22:21:26.272 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.273 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou
03-04 22:21:26.273 15657 15684 V python  : extracting ././@LongLink
03-04 22:21:26.273 15657 15684 V python  : extracting crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou
03-04 22:21:26.275 15657 15684 E python  : could not open /data/user/0/org.test.testapp_python3/files/app/crystax_python/site-packages/home/asandy/devel/pyenv/versions/3.5.0/share/kivy-examples/miscellaneou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants